Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #126
📝 Description
This PR was a simple backend update to fix makes donations support reoccurances. We had an implementation suggested in the ticket, which I followed pretty closely. I also made a migration for these changes, ensuring that all fields were considered nullable, until the reoccurance field became somehting other than once.
I also altered the backend create endpoint accordingly. I made it so that, if the recurrance type is not ONCE, then all 3 other fields need to be filled out, or we cannot create a donation.
The idea with this migration now, is that we can easily implement recurruing donations as follows
nextDonationDatesarray✔️ Verification
🏕️ (Optional) Future Work / Notes
Now that we have this, we need to being handling actually updating the endpoint daily. This will include the following: